On Wed, Nov 19, 2008 at 02:51:40PM -0800, Andrew Morton wrote: > again: what was wrong with the old code?? > > If it was causing some compilation problem then please quote the compiler > output in the changelog. I didn't write this patch, but I was the original author of this driver. The issue here is that Apple added a journal feature after the fact and the current Linux driver doesn't support that. The current code just checks for the equivalent of a feature bit, while this change makes it also confirm that there really is a journal file. Without this change, an HFS+ file system that has been setup to do transactional changes but doesn't currently have an actual journal file allocated will not be mountable with the Linux driver. Just as a side note, although I am the original author I have never claimed to maintain this code. In fact, I wasn't the one that submitted it for inclusion. In any case, I don't plan on adding myself as maintainer. Brad Boyer flar@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html