Re: [PATCH] cachefiles: Drop superfluous readpages aops NULL check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] cachefiles: Drop superfluous readpages aops NULL check
From: David Howells <dhowells@xxxxxxxxxx>
Date: Wed, 20 Jan 2021 16:12:09 +0000
Cc: dhowells@xxxxxxxxxx, Takashi Iwai <tiwai@xxxxxxx>, dwysocha@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "Matthew Wilcox \(Oracle\)" <willy@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, linux-afs@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20201020075307.GA17780@infradead.org>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> what prevents us from killing of the last ->readpages instance?
> Leaving half-finished API conversions in the tree usually doesn't end
> well..

I never got around to making cachefiles actually use ->readpages, so that's
not an issue.

David

References:
- Re: [PATCH] cachefiles: Drop superfluous readpages aops NULL check
  - From: Christoph Hellwig
- [PATCH] cachefiles: Drop superfluous readpages aops NULL check
  - From: David Howells

Prev by Date: [PATCH] cachefiles: Drop superfluous readpages aops NULL check
Next by Date: Re: [PATCH 1/3] mm: Do not pass iter into generic_file_buffered_read_get_pages()
Previous by thread: Re: [PATCH] cachefiles: Drop superfluous readpages aops NULL check
Next by thread: [PATCH] cachefiles: Drop superfluous readpages aops NULL check
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]