Re: [PATCH v17 02/10] fs/ntfs3: Add initialization of super block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 19, 2021 at 06:03:06AM +0200, Kari Argillander wrote:
> On Thu, Dec 31, 2020 at 06:23:53PM +0300, Konstantin Komarov wrote:
> > diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c

> > +struct ntfs_fnd *fnd_get(struct ntfs_index *indx)
> > +{
> > +	struct ntfs_fnd *fnd = ntfs_alloc(sizeof(struct ntfs_fnd), 1);
> > +
> > +	if (!fnd)
> > +		return NULL;
> > +
> > +	return fnd;
> > +}
> 
> This should be initilized. What about that indx. Is that neccasarry?
> Also no need to check NULL because if it is NULL we can just return it. 

Sorry about initilized part. Didn't notice it was kzalloc. Other parts
are still relevent.




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux