On Mon, Jan 18, 2021 at 09:35:05AM +0000, Konstantin Komarov wrote: > From: Kari Argillander <kari.argillander@xxxxxxxxx> > Sent: Sunday, January 3, 2021 10:50 PM > > On Thu, Dec 31, 2020 at 06:23:53PM +0300, Konstantin Komarov wrote: > > > diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c > > > > > +int ntfs_create_inode(struct inode *dir, struct dentry *dentry, > > > + const struct cpu_str *uni, umode_t mode, dev_t dev, > > > + const char *symname, u32 size, int excl, > > > + struct ntfs_fnd *fnd, struct inode **new_inode) > > > +{ > > > > > +#ifdef CONFIG_NTFS3_FS_POSIX_ACL > > > > In Kconfig this is NTFS3_POSIX_ACL. This repeat every file. > > > > This is OK. You may refer to similar parts of ext4/btrfs sources as a > reference: > fs/ext4/Kconfig or fs/btrfs/Kconfig > But in ext4 and btrfs Kconfig specify *_FS_POSIX_ACL. In ntfs3 Kconfig specify *_POSIX_ACL. So we missing _FS_ in our Kconfig?