On Mon, Jan 04, 2021 at 04:54:51PM -0800, Eric Biggers wrote: > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > The comment in xfs_file_aio_write_checks() about calling file_modified() > after dropping the ilock doesn't make sense, because the code that > unconditionally acquires and drops the ilock was removed by > commit 467f78992a07 ("xfs: reduce ilock hold times in > xfs_file_aio_write_checks"). > > Remove this outdated comment. Yes, this looks good, I actually have the removal included in a WIP patch as well, but splitting it out like this look good to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx>