Re: [PATCH v2] binfmt_elf: Fix fill_prstatus() call in fill_note_info()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 06, 2021 at 08:51:12AM +0100, Geert Uytterhoeven wrote:
> On m68k, which does not define CORE_DUMP_USE_REGSET:
> 
>     fs/binfmt_elf.c: In function ‘fill_note_info’:
>     fs/binfmt_elf.c:2040:20: error: passing argument 1 of ‘fill_prstatus’ from incompatible pointer type [-Werror=incompatible-pointer-types]
>      2040 |  fill_prstatus(info->prstatus, current, siginfo->si_signo);
> 	  |                ~~~~^~~~~~~~~~
> 	  |                    |
> 	  |                    struct elf_prstatus *
>     fs/binfmt_elf.c:1498:55: note: expected ‘struct elf_prstatus_common *’ but argument is of type ‘struct elf_prstatus *’
>      1498 | static void fill_prstatus(struct elf_prstatus_common *prstatus,
> 	  |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
> 
> The fill_prstatus() signature was changed, but one caller was not
> updated.
> 
> Reported-by: noreply@xxxxxxxxxxxxxx
> Fixes: 147d88b334cd5416 ("elf_prstatus: collect the common part (everything before pr_reg) into a struct")
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
> Compile-tested only.  Feel free to fold into the original commit.

Thanks, folded and pushed out...



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux