On Tue, Dec 22, 2020 at 10:03 PM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > > remove_arg_zero is declared as __must_check. Looks like it can return > -EFAULT on failure. > > Cc: Masahiro Yamada <masahiroy@xxxxxxxxxx> > Cc: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> > Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx> > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> Cc'ing Alpha list too. Alexander, fs-devel: pinging about this... We removed ENABLE_MUST_CHECK in 196793946264 ("Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK"), so this should be giving a warning now unconditionally. In 5.12 it will likely become a build error. Nick: thanks for the patch! (I missed it in December, sorry) Reviewed-by: Miguel Ojeda <ojeda@xxxxxxxxxx> Cheers, Miguel