On Mon, 2008-11-10 at 10:08 +1100, Dave Chinner wrote: > On Fri, Nov 07, 2008 at 09:20:30AM -0600, James Bottomley wrote: > > On Fri, 2008-11-07 at 07:14 -0500, Ric Wheeler wrote: > > > Jens Axboe wrote: > > > I think that discard merging would be helpful (especially for devices > > > with more reasonable sized unmap chunks). > > > > One of the ways the unmap command is set up is with a disjoint > > scatterlist, so we can send a large number of unmaps together. Whether > > they're merged or not really doesn't matter. > > > > The probable way a discard system would work if we wanted to endure the > > complexity would be to have the discard system in the underlying device > > driver (or possibly just above it in block, but different devices like > > SCSI or ATA have different discard characteristics). It would just > > accumulate block discard requests as ranges (and it would have to poke > > holes in the ranges as it sees read/write requests) which it flushes > > periodically. > > It appears to me that discard requests are only being considered > here at a block and device level, and nobody is thinking about > the system level effects of such aggregation of discard requests. > > What happens on a system crash? We lose all the pending discard > requests, never to be sent again? Yes ... since this is for thin provisioning. Discard is best guess ... it doesn't affect integrity if we lose one and from the point of view of the array, 99% transmitted is far better than we do today. All that happens for a lost discard is that the array keeps a block that the filesystem isn't currently using. However, the chances are that it will get reused, so it shares a good probability of getting discarded again. > If so, how do we tell the device > that certain ranges have actually been discarded after the crash? > Are you expecting them to get replayed by a filesystem during > recovery? What if it was a userspace discard from something like > mkfs that was lost? How does this interact with sync or other > such user level filesystems synchronisation primitives? Does > sync_blockdev() flush out pending discard requests? Should fsync? No .. the syncs are all integrity based. Discard is simple opportunity based. > And if the filesystem has to wait for discard requests to complete > to guarantee that they are done or can be recovered and replayed > after a crash, most filesystems are going to need modification. e.g. > XFS would need to prevent the tail of the log moving forward until > the discard request associated with a given extent free transaction > has been completed. That means we need to be able to specifically > flush queued discard requests and we'd need I/O completions to > run when they are done to do the filesytem level cleanup work.... OK, I really don't follow the logic here. Discards have no effect on data integrity ... unless you're confusing them with secure deletion? A discard merely tells the array that it doesn't need to back this block with an actual storage location anymore (until the next write for that region comes down). The ordering worry can be coped with in the same way we do barriers ... it's even safer for discards because if we know the block is going to be rewritten, we simply discard the discard. > Let's keep the OS level interactions simple - if the array vendors > want to keep long queues of requests around before acting on them > to aggregate them, then that is an optimisation for them to > implement. They already do this with small data writes to NVRAM, so I > don't see how this should be treated any differently... Well, that's Chris' argument, and it has merit. I'm coming from the point of view that discards are actually a fundamentally different entity from anything else we process. James -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
