Re: [External] Re: [PATCH v10 03/11] mm/hugetlb: Free the vmemmap pages associated with each HugeTLB page

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Muchun Song <songmuchun@xxxxxxxxxxxxx>
Subject: Re: [External] Re: [PATCH v10 03/11] mm/hugetlb: Free the vmemmap pages associated with each HugeTLB page
From: Oscar Salvador <osalvador@xxxxxxx>
Date: Mon, 21 Dec 2020 14:43:53 +0100
Cc: Jonathan Corbet <corbet@xxxxxxx>, Mike Kravetz <mike.kravetz@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, mingo@xxxxxxxxxx, bp@xxxxxxxxx, x86@xxxxxxxxxx, hpa@xxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, luto@xxxxxxxxxx, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, viro@xxxxxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, paulmck@xxxxxxxxxx, mchehab+huawei@xxxxxxxxxx, pawan.kumar.gupta@xxxxxxxxxxxxxxx, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, oneukum@xxxxxxxx, anshuman.khandual@xxxxxxx, jroedel@xxxxxxx, Mina Almasry <almasrymina@xxxxxxxxxx>, David Rientjes <rientjes@xxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxx>, "Song Bao Hua (Barry Song)" <song.bao.hua@xxxxxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, naoya.horiguchi@xxxxxxx, Xiongchun duan <duanxiongchun@xxxxxxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Linux Memory Management List <linux-mm@xxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>
In-reply-to: <CAMZfGtVnS=_m4fpGBfDpOpdgzP02QCteUQn-gGiLADWfGiVJ=A@mail.gmail.com>
User-agent: Mutt/1.10.1 (2018-07-13)

On Mon, Dec 21, 2020 at 07:25:15PM +0800, Muchun Song wrote:

> Should we add a BUG_ON in vmemmap_remap_free() for now?
> 
>         BUG_ON(reuse != start + PAGE_SIZE);

I do not think we have to, plus we would be BUG_ing for some specific use
case in "generic" function.
Maybe others think different though.

-- 
Oscar Salvador
SUSE L3

Follow-Ups:
- Re: [External] Re: [PATCH v10 03/11] mm/hugetlb: Free the vmemmap pages associated with each HugeTLB page
  - From: Muchun Song

References:
- [PATCH v10 00/11] Free some vmemmap pages of HugeTLB page
  - From: Muchun Song
- [PATCH v10 03/11] mm/hugetlb: Free the vmemmap pages associated with each HugeTLB page
  - From: Muchun Song
- Re: [PATCH v10 03/11] mm/hugetlb: Free the vmemmap pages associated with each HugeTLB page
  - From: Oscar Salvador
- Re: [External] Re: [PATCH v10 03/11] mm/hugetlb: Free the vmemmap pages associated with each HugeTLB page
  - From: Muchun Song

Prev by Date: [PATCH] fs: binfmt_em86: check the result of remove_arg_zero()
Next by Date: Re: set_page_dirty vs truncate
Previous by thread: Re: [External] Re: [PATCH v10 03/11] mm/hugetlb: Free the vmemmap pages associated with each HugeTLB page
Next by thread: Re: [External] Re: [PATCH v10 03/11] mm/hugetlb: Free the vmemmap pages associated with each HugeTLB page
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]