On Wed, Dec 16, 2020 at 9:28 PM Oscar Salvador <osalvador@xxxxxxx> wrote: > > On Sun, Dec 13, 2020 at 11:45:29PM +0800, Muchun Song wrote: > > Because we reuse the first tail vmemmap page frame and remap it > > with read-only, we cannot set the PageHWPosion on a tail page. > > So we can use the head[4].private to record the real error page > > index and set the raw error page PageHWPoison later. > > Maybe the following is better? > > "Since the first page of tail page structs is remapped read-only, > we cannot modify any tail struct page, and so we cannot set > the HWPoison flag on a tail page. > We can make use of head[4].private to record the real hwpoisoned > page index. > Right before freeing the page the real raw page will be retrieved > and marked as HWPoison. > " > > I think it is slighly clearer, but whatever. Thank you. > > > Signed-off-by: Muchun Song <songmuchun@xxxxxxxxxxxxx> > > I do not quite like the name hwpoison_subpage_deliver, but I cannot > come up with a better one myself, so: > > Reviewed-by: Oscar Salvador <osalvador@xxxxxxx> Thanks for your review. > > -- > Oscar Salvador > SUSE L3 -- Yours, Muchun
