On Thu, Nov 06, 2008 at 05:15:53PM +0100, Christian Borntraeger wrote: > Am Donnerstag, 6. November 2008 schrieb Peter Staubach: > > > /* We allocate both existing and potentially added groups */ > > > flex_group_count = ((sbi->s_groups_count + groups_per_flex - 1) + > > > - ((sbi->s_es->s_reserved_gdt_blocks +1 ) << > > > + (le16_to_cpu(sbi->s_es->s_reserved_gdt_blocks + 1) << > > > > > > > I suspect that you want to do the le16_to_cpu() and _then_ > > add the 1. Otherwise, adding 1 to a different byte order > > value won't do quite what is expected or hoped for... > > errm. Right. > Something like this maybe? > > [PATCH]: ext4: fix big endian access for flex groups > > On big endianess plattforms newly created ext4 file systems cannot be mounted > and show messages like: > [6923911.715968] EXT4-fs: not enough memory for 522250 flex groups > [6923911.715973] EXT4-fs: unable to initialize flex_bg meta info! > > We have to access s_reserved_gdb_blocks with le16_to_cpu. > > Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx> There is already a patch in the patchqueue that fix this http://repo.or.cz/w/ext4-patch-queue.git?a=blob;f=convert-to-host-order-in-ext4_fill_flex_info;h=ebe7efb3ee78b6cab4db49391f4a005d78a26f03;hb=HEAD -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
