On Fri, 2008-10-31 at 14:30 +0000, steve@xxxxxxxxxxx wrote: > > ntfs and gfs2 each have a check that assumes WB_SYNC_NONE means optional > > writeback, both seem fixable with one liners. > > > I doubt that is the case for GFS2... Its a bit subtle, but in order to > ensure that we have the correct lock ordering the code in writepage > for jdata (the only place this occurs, and I assume is what you are > referring to) relies in the fact that because we have a writepages > set for jdata, writepage will only ever be called with WB_SYNC_NONE > and can thus be skipped. Well, if you have a writepages call, writepage is only used by kswapd and is entirely optional (assuming you don't call it yourself ;) -chris -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
