On Wed, Oct 29, 2008 at 05:13:26AM -0400, Christoph Hellwig wrote: > On Wed, Oct 29, 2008 at 02:26:01PM +1100, Dave Chinner wrote: > > Ok, I was right - these problems happen all the time. The above call > > should really call xfs_flush_pages() to do the flush and wait. I > > note that xfs_flush_pages() returns negative errors, and all the > > callers expect positive errors. I bet the same occurs for > > xfs_flushinval_pages() and xfs_tosspages() which are the wrappers > > that core XFS code is supposed to be using for flushing and > > invalidating file ranges.... > > > > I'll write up a patch that covers all of these. > > Can you also merge xfs_fsync into xfs_file_fsync while you're at it? > The split newer made any sense as xfs_fsync is as Linux-specific as it > gets and shouldn't be in the pseudo OS-independent layer. I'll do that as a separate patch - it's not really part of a "fix error value inversion" bug fix.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
