On Mon 27-10-08 22:55:10, Andrew Morton wrote:
> On Mon, 27 Oct 2008 13:11:51 +0100 Jan Kara <jack@xxxxxxx> wrote:
>
> > + printk(KERN_WARNING "Not enough memory for quota information"
> > + "structure.\n");
>
> Linus goes apeshit when he catches us doing this (it makes the error
> message hard to grep for). We can fix it this way:
OK, noted. Thanks.
Honza
> --- a/fs/quota_v2.c~quota-convert-union-in-mem_dqinfo-to-a-pointer-cleanup
> +++ a/fs/quota_v2.c
> @@ -83,8 +83,8 @@ static int v2_read_file_info(struct supe
> }
> info->dqi_priv = kmalloc(sizeof(struct qtree_mem_dqinfo), GFP_NOFS);
> if (!info->dqi_priv) {
> - printk(KERN_WARNING "Not enough memory for quota information"
> - "structure.\n");
> + printk(KERN_WARNING
> + "Not enough memory for quota information structure.\n");
> return -1;
> }
> qinfo = info->dqi_priv;
>
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
