Re: kernel BUG at fs/ext4/inode.c:LINE!

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Hugh Dickins <hughd@xxxxxxxxxx>
Subject: Re: kernel BUG at fs/ext4/inode.c:LINE!
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Tue, 24 Nov 2020 15:24:56 -0800
Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, syzbot <syzbot+3622cea378100f45d59f@xxxxxxxxxxxxxxxxxxxxxxxxx>, Andreas Dilger <adilger.kernel@xxxxxxxxx>, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, syzkaller-bugs <syzkaller-bugs@xxxxxxxxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, Linux-MM <linux-mm@xxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, "Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Alex Shi <alex.shi@xxxxxxxxxxxxxxxxx>, Qian Cai <cai@xxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, William Kucharski <william.kucharski@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, linux-xfs <linux-xfs@xxxxxxxxxxxxxxx>
In-reply-to: <alpine.LSU.2.11.2011241322540.1777@eggly.anvils>

On Tue, Nov 24, 2020 at 1:47 PM Hugh Dickins <hughd@xxxxxxxxxx> wrote:
>
> I think the unreferenced struct page asks for trouble.

I do agree.

I've applied your second patch (the smaller one that just takes a ref
around the critical section). If somebody comes up with some great
alternative, we can always revisit this.

            Linus

Follow-Ups:
- Re: kernel BUG at fs/ext4/inode.c:LINE!
  - From: Linus Torvalds

References:
- Re: kernel BUG at fs/ext4/inode.c:LINE!
  - From: Hugh Dickins
- Re: kernel BUG at fs/ext4/inode.c:LINE!
  - From: Matthew Wilcox
- Re: kernel BUG at fs/ext4/inode.c:LINE!
  - From: Hugh Dickins
- Re: kernel BUG at fs/ext4/inode.c:LINE!
  - From: Matthew Wilcox
- Re: kernel BUG at fs/ext4/inode.c:LINE!
  - From: Linus Torvalds
- Re: kernel BUG at fs/ext4/inode.c:LINE!
  - From: Matthew Wilcox
- Re: kernel BUG at fs/ext4/inode.c:LINE!
  - From: Linus Torvalds
- Re: kernel BUG at fs/ext4/inode.c:LINE!
  - From: Hugh Dickins

Prev by Date: RE: [PATCH] exfat: Avoid allocating upcase table using kcalloc()
Next by Date: Re: [PATCH 0/5] fscrypt: prevent creating duplicate encrypted filenames
Previous by thread: Re: kernel BUG at fs/ext4/inode.c:LINE!
Next by thread: Re: kernel BUG at fs/ext4/inode.c:LINE!
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]