On Wed, Nov 18, 2020 at 03:37:47PM +0100, Jan Kara wrote: > > -static inline dev_t blk_lookup_devt(const char *name, int partno) > > -{ > > - dev_t devt = MKDEV(0, 0); > > - return devt; > > -} > > #endif /* CONFIG_BLOCK */ > > This hunk looks unrelated to the change? Also why you move the declaration > outside the CONFIG_BLOCK ifdef? AFAICS blk_lookup_devt() still exists only > when CONFIG_BLOCK is defined? Otherwise the patch looks good to me. blk_lookup_devt is a hack only for name_to_dev_t only referenced from code under CONFIG_BLOCK now, as it didn't do anything before when blk_lookup_devt returned 0. I guess I'll need to update the commit log a little to mention this.