On Mon, 27 Oct 2008 13:11:39 +0100 Jan Kara <jack@xxxxxxx> wrote:
> +static void destroy_dquot(struct dquot *dquot)
> +{
> + if (dquot->dq_sb->dq_op->destroy_dquot)
> + dquot->dq_sb->dq_op->destroy_dquot(dquot);
> + else
> + kmem_cache_free(dquot_cachep, dquot);
> +}
Could we require that all dquot_operations.destroy_dquot() be non-NULL?
Make it point at
void default_destroy_dquot(struct dquot *dquot)
{
kmem_cache_fre(...);
}
(and ditto dquot_operations.alloc_qduot).
That way the above becomes a simple inlined function with no `if'.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
