This response is a bit confusing, let me try to fix that.
On Tue, 2008-10-28 at 09:27 +0900, Ian Kent wrote:
> On Mon, 2008-10-27 at 13:31 -0700, Andrew Morton wrote:
> > On Thu, 23 Oct 2008 10:35:22 +0800
> > Ian Kent <raven@xxxxxxxxxx> wrote:
> >
> > > Remove unnecessary string terminator check.
> >
> > Why is it unnecessary?
> >
> > Does this change alter behaviour in any way?
> >
> > Does it fix a bug?
>
> Umm .... it was done in response to your comment, quoted below ...
>
<quote>
> > +/*
> > + * Check a string doesn't overrun the chunk of
> > + * memory we copied from user land.
> > + */
> > +static int invalid_str(char *str, void *end)
> > +{
> > + while ((void *) str <= end)
> > + if (!*str++)
> > + return 0;
> > + return -EINVAL;
> > +}
>
> What is this? We copy strings in from userspace in 10000 different
> places without needing checks such as this?
</quote>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
