On 11/18/20 5:10 PM, Greg KH wrote: > On Wed, Nov 18, 2020 at 04:54:51PM +0800, Coly Li wrote: >> On 11/18/20 4:47 PM, Christoph Hellwig wrote: >>> Don't bother to call lookup_bdev for just a slightly different error >>> message without any functional change. >>> >>> Signed-off-by: Christoph Hellwig <hch@xxxxxx>ist >> >> Hi Christoph, >> >> NACK. This removing error message is frequently triggered and observed, >> and distinct a busy device and an already registered device is important >> (the first one is critical error and second one is not). >> >> Remove such error message will be a functional regression. > > What normal operation causes this error message to be emitted? And what > can a user do with it? When there was bug and the caching or backing device was not unregistered successfully, people could see "device busy"; and if it was because the device registered again, it could be "already registered". Without the different message, people may think the device is always busy but indeed it isn't. he motivation of the patch is OK to me, but we need to make the logical consistent, otherwise we will have similar bug report for bogus warning dmesg from bcache users in soon future. Coly Li
