On Thu, Nov 12, 2020 at 09:26:31PM +0000, Matthew Wilcox (Oracle) wrote: > + if (mark == XA_PRESENT) > + page = xas_find(xas, max); > + else > + page = xas_find_marked(xas, max, mark); Is there any good reason xas_find_marked can't handle the XA_PRESENT case as well? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>