On Tue, Oct 27, 2020 at 06:56:42PM +0000, Christoph Hellwig wrote: > > +static inline struct page *xas_find_get_entry(struct xa_state *xas, > > + pgoff_t max, xa_mark_t mark) > > I'd expect the xas_ prefix for function from xarray.h. Maybe this > wants a better name? The obvious name for this is find_get_entry(). But that already exists. Although it turns out it has only two users and one of them doesn't actually want to use it, so I'm going to rename find_get_entry() to mapping_get_entry() and then this can become find_get_entry().