On 2020/11/12 16:35, Johannes Thumshirn wrote: > On 12/11/2020 08:00, Anand Jain wrote: >>> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c >>> index 8840a4fa81eb..ed55014fd1bd 100644 >>> --- a/fs/btrfs/super.c >>> +++ b/fs/btrfs/super.c >>> @@ -2462,6 +2462,11 @@ static void __init btrfs_print_mod_info(void) >>> #endif >>> #ifdef CONFIG_BTRFS_FS_REF_VERIFY >>> ", ref-verify=on" >>> +#endif >>> +#ifdef CONFIG_BLK_DEV_ZONED >>> + ", zoned=yes" >>> +#else >>> + ", zoned=no" >>> #endif >> IMO, we don't need this, as most of the generic kernel will be compiled >> with the CONFIG_BLK_DEV_ZONED defined. >> For review purpose we may want to know if the mounted device >> is a zoned device. So log of zone device and its type may be useful >> when we have verified the zoned devices in the open_ctree(). >> > > David explicitly asked for this in [1] so we included it. > > [1] https://lore.kernel.org/linux-btrfs/20201013155301.GE6756@xxxxxxxxxxxxx > And as of now, not all generic kernels are compiled with CONFIG_BLK_DEV_ZONED. E.g. RHEL and CentOS. That may change in the future, but it should not be assumed that CONFIG_BLK_DEV_ZONED is always enabled. -- Damien Le Moal Western Digital Research
