Re: [PATCH v3 03/18] mm/filemap: Convert filemap_get_pages to take a pagevec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 10, 2020 at 07:21:18PM +0100, Christoph Hellwig wrote:
> On Tue, Nov 10, 2020 at 03:36:48AM +0000, Matthew Wilcox (Oracle) wrote:
> > Using a pagevec lets us keep the pages and the number of pages together
> > which simplifies a lot of the calling conventions.
> > 
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> 
> I hate the > 80 char lines in a few spots, but otherwise this looks good:

They're all gone by the end of this series.  It's just less churn to
ignore the 80 columns limit for the intermediate patches.

> Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux