> +int bio_add_zone_append_page(struct bio *bio, struct page *page,
> + unsigned int len, unsigned int offset)
> +{
> + struct request_queue *q;
> + bool same_page = false;
> +
> + if (WARN_ON_ONCE(bio_op(bio) != REQ_OP_ZONE_APPEND))
> + return 0;
> +
> + if (WARN_ON_ONCE(!bio->bi_disk))
> + return 0;
Do we need this check? I'd rather just initialize q at declaration time
and let the NULL pointer deref be the obvious sign for a grave
programming error..
Except for that the patch looks good to me:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
