On Tue, Nov 03, 2020 at 01:48:34PM +0100, David Sterba wrote:
On Fri, Oct 30, 2020 at 10:51:14PM +0900, Naohiro Aota wrote:
INODE_MAP_CACHE inode.
In summary, ZONED will disable:
| Disabled features | Reason |
|-------------------+-----------------------------------------------------|
| RAID/Dup | Cannot handle two zone append writes to different |
| | zones |
|-------------------+-----------------------------------------------------|
| space_cache (v1) | In-place updating |
| NODATACOW | In-place updating |
|-------------------+-----------------------------------------------------|
| fallocate | Reserved extent will be a write hole |
| INODE_MAP_CACHE | Need pre-allocation. (and will be deprecated?) |
space_cache is deprecated and actually in current dev cycle (5.11)
|-------------------+-----------------------------------------------------|
| MIXED_BG | Allocated metadata region will be write holes for |
| | data writes |
Signed-off-by: Naohiro Aota <naohiro.aota@xxxxxxx>
---
fs/btrfs/super.c | 12 ++++++++++--
fs/btrfs/zoned.c | 18 ++++++++++++++++++
fs/btrfs/zoned.h | 5 +++++
3 files changed, 33 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 3312fe08168f..9064ca62b0a0 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -525,8 +525,14 @@ int btrfs_parse_options(struct btrfs_fs_info *info, char *options,
cache_gen = btrfs_super_cache_generation(info->super_copy);
if (btrfs_fs_compat_ro(info, FREE_SPACE_TREE))
btrfs_set_opt(info->mount_opt, FREE_SPACE_TREE);
- else if (cache_gen)
- btrfs_set_opt(info->mount_opt, SPACE_CACHE);
+ else if (cache_gen) {
+ if (btrfs_is_zoned(info)) {
+ btrfs_info(info,
+ "clearring existing space cache in ZONED mode");
"zoned: clearing existing space cache"
Is it clearing or just invalidating it? We have the same problem with
enabling v2 so this could share some code once Boris' patches are
merged.
Yep, this is just invalidating it. I'll use
btrfs_set_free_space_cache_v1_active here once the patches are merged.
