Re: [PATCH 2/2] fuse: Implement O_TMPFILE support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 10, 2020 at 4:33 AM Chirantan Ekbote <chirantan@xxxxxxxxxxxx> wrote:

> That's not the behavior I observed.  Without this, the O_TMPFILE flag
> gets passed through to the server.  The call stack is:
>
> - do_filp_open
>     - path_openat
>         - do_tmpfile
>             - vfs_tmpfile
>                 - dir->i_op->tmpfile
>             - finish_open
>                 - do_dentry_open
>                     - f->f_op->open
>
> and I didn't see O_TMPFILE being removed anywhere in there.

Ah, indeed.

The reason I missed this is because IMO the way it *should* work is
that FUSE_TMPFILE creates and opens the file in one go.  We shouldn't
need two separate request.

Not sure how we should go about this... The ->atomic_open() API is
sufficient, but maybe we want a new ->atomic_tmpfile().

Al?

Thanks,
Miklos



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux