> + if (mapping->host->i_blkbits >= (PAGE_SHIFT + thp_order(page))) > + return false; > + > + pos = (loff_t) page->index << PAGE_SHIFT; Should this use page_offset() ? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> + if (mapping->host->i_blkbits >= (PAGE_SHIFT + thp_order(page))) > + return false; > + > + pos = (loff_t) page->index << PAGE_SHIFT; Should this use page_offset() ? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>