On Tue, Nov 03, 2020 at 03:18:47PM +0000, Matthew Wilcox wrote: > I have a simplification in mind that gets rid of the awkward 'first' > parameter. In filemap_get_pages(), do: > > if ((iocb->ki_flags & IOCB_WAITQ) && (pagevec_count(pvec) > 1)) > iocb->ki_flags |= IOCB_NOWAIT; > > before calling filemap_update_page(). That matches what Kent did in > filemap_read(): Yes, that makes a lot of sense. No need for the second pair of inner braces, though :)