On Nov 2, 2020, at 2:58 PM, Alejandro Colomar <colomar.6.4.3@xxxxxxxxx> wrote: > Changes: > - Consistently use 'unsigned int', instead of 'unsigned'. > - Add a blank line after variable declarations. > - Move variable declarations to the top of functions. > - Add a blank line at the top of functions if there are no declarations. I'd agree that the other changes are following kernel coding style, but I've never heard of leaving a blank line at the start of functions without any local variables. I don't see anything in process/coding-style.rst to support this change, nor are the majority of variable-less functions formatted this way, and it seems to just be a waste of vertical space. Cheers, Andreas
Attachment:
signature.asc
Description: Message signed with OpenPGP
