Re: Subject: [PATCH 04/16] Squashfs: regular file operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 17 Oct 2008, Phillip Lougher wrote:
> --- /dev/null
> +++ b/fs/squashfs/file.c
> +static long long read_blocklist(struct inode *inode, int index,
> +				unsigned int *bsize)
> +{
> +	long long start, block, blks;
> +	int offset;
> +	__le32 size;
> +	int res = fill_meta_index(inode, index, &start, &offset, &block);
> +
> +	TRACE("read_blocklist: res %d, index %d, start 0x%llx, offset"
> +		       " 0x%x, block 0x%llx\n", res, index, start, offset,
> +			block);
> +
> +	if (res == -1)
> +		goto failure;
                ^^^^^^^^^^^^^

> +		if (blks == -1)
> +			goto failure;
			^^^^^^^^^^^^^

> +	if (res == 0)
> +		goto failure;
                ^^^^^^^^^^^^^

> +failure:
> +	return -1;
> +}

As there's nothing to clean up, you can just use `return -1' instead of `goto
failure', and save a few lines.

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Techsoft Centre Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone:    +32 (0)2 700 8453
Fax:      +32 (0)2 700 8622
E-mail:   Geert.Uytterhoeven@xxxxxxxxxxx
Internet: http://www.sony-europe.com/

A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 · RPR Brussels
Fortis · BIC GEBABEBB · IBAN BE41293037680010

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux