On Tue, Oct 21, 2008 at 02:35:18PM -0700, Andrew Morton wrote: > On Tue, 21 Oct 2008 08:20:20 +0200 > Nick Piggin <npiggin@xxxxxxx> wrote: > > > Nothing uses prepare_write or commit_write. Remove them from the tree > > completely. > > We could withdraw simple_prepare_write() too, I guess. But there's > some risk that out-of-tree filesystems might be using it within their > write_begin() implementations. That's true. A number of the helper functions are still write_begin implemented by calling into prepare_write... Of course, after this patch, the bare prepare_write functions won't be any use to external modules anymore. At least the code still gets exercised and no hacks, though. With the perform_write_2copy stuff, it almost becomes crazy for us to support given that very few in-kernel users (and now one) ever test it. Anyway... this has taken long enough that I don't much care exactly how it gets merged. Whatever you think best. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
