On Fri, Oct 16, 2020 at 09:56:08AM -0700, Keith Busch wrote: > On Fri, Oct 16, 2020 at 05:14:26PM +0100, Matthew Wilcox (Oracle) wrote: > > + err = submit_bio_killable(args.bio, mpage_end_io); > > + if (unlikely(err)) > > + goto err; > > + > > + SetPageUptodate(page); > > On success, isn't the page already set up to date through the > mpage_end_io() callback? On success, mpage_end_io() isn't called. And we don't want it to be because we don't want the page to be unlocked. I should probably have included a reference to https://lore.kernel.org/linux-fsdevel/20201016160443.18685-1-willy@xxxxxxxxxxxxx/
