Thanks Sedat, I'll take care of this in V10. On Fri, Oct 9, 2020 at 8:14 PM Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote: > > On Fri, Oct 9, 2020 at 6:04 PM harshad shirwadkar > <harshadshirwadkar@xxxxxxxxx> wrote: > > > > Thanks Sedat for pointing that out and also sending out the fixes. > > Ted, should I send out another version of fast commits out with > > Sedat's fixes? > > > > Hi Harshad, > > when you work on v10, can you look at these warnings, please? > > fs/jbd2/recovery.c:241:15: warning: unused variable 'seq' [-Wunused-variable] > fs/ext4/fast_commit.c:1091:6: warning: variable 'start_time' is used > uninitialized whenever 'if' condition is true > [-Wsometimes-uninitialized] > fs/ext4/fast_commit.c:1091:6: warning: variable 'start_time' is used > uninitialized whenever '||' condition is true > [-Wsometimes-uninitialized] > > Thanks, > - Sedat - > > P.S.: Now, I see that ext4.git#dev has dropped the hs/fast-commit v9 merge. > > > > > > > On Fri, Oct 9, 2020 at 8:45 AM Theodore Y. Ts'o <tytso@xxxxxxx> wrote: > > > > > > On Fri, Oct 09, 2020 at 04:31:51PM +0200, Sedat Dilek wrote: > > > > > This fixes it... > > > > > > Sedat, > > > > > > Thanks for the report and the proposed fixes! > > > > > > - Ted
