On Fri, Oct 09, 2020 at 12:18:23PM +0200, Sedat Dilek wrote: > > > Fixes: tag should be 12 digits (see [1]). > > > ( Seen while walking through ext-dev Git commits. ) > > > > Thanks Sedat, I guess it should be minimum 12 chars [1] Right, the point is that the commit ID referenced should be at least 12 bytes to avoid ambiguity. There's nothing really wrong with using more than 12 bytes. I sometimes use 16, myself. It does look like there is a (mostly harmless) inconsistency between lines 177 and 183 of submitting-patches.rst. > In my ~/.gitconfig: > > [core] > abbrev = 12 > > # Check for 'Fixes:' tag used in the Linux-kernel development process > (Thanks Kalle Valo).2 > # Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst > # Usage: $ git log --format=fixes | head -5 > [pretty] > fixes = Fixes: %h (\"%s\") > > Hope this is useful for others. Personally, I find cutting and pasting the full SHA-1 hash and description, and then cutting down the hash in emacs to be more convenient, since I generaslly have the git commit from "git log" in terminal window anyway. But whatever works for each developer. :-) - Ted
