Re: [PATCH 5/7] btrfs: Promote to unsigned long long before shifting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 5/7] btrfs: Promote to unsigned long long before shifting
From: Josef Bacik <josef@xxxxxxxxxxxxxx>
Date: Fri, 9 Oct 2020 10:18:01 -0400
Cc: ericvh@xxxxxxxxx, lucho@xxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, jlayton@xxxxxxxxxx, idryomov@xxxxxxxxx, mark@xxxxxxxxxx, jlbec@xxxxxxxxxxxx, joseph.qi@xxxxxxxxxxxxxxxxx, v9fs-developer@xxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, clm@xxxxxx, dsterba@xxxxxxxx, stable@xxxxxxxxxxxxxxx
In-reply-to: <20201004180428.14494-6-willy@infradead.org>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 10/4/20 2:04 PM, Matthew Wilcox (Oracle) wrote:

On 32-bit systems, this shift will overflow for files larger than 4GB.

Cc: stable@xxxxxxxxxxxxxxx
Fixes: df480633b891 ("btrfs: extent-tree: Switch to new delalloc space reserve and release")
Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>


Reviewed-by: Josef Bacik <josef@xxxxxxxxxxxxxx>

Thanks,

Josef

References:
- [PATCH 0/7] Fix a pile of 4GB file problems on 32-bit
  - From: Matthew Wilcox (Oracle)
- [PATCH 5/7] btrfs: Promote to unsigned long long before shifting
  - From: Matthew Wilcox (Oracle)

Prev by Date: Re: ext4: dev: Broken with CONFIG_JBD2=and CONFIG_EXT4_FS=m
Next by Date: Re: [PATCH 6/7] btrfs: Promote to unsigned long long before shifting
Previous by thread: [PATCH 5/7] btrfs: Promote to unsigned long long before shifting
Next by thread: Re: [PATCH 5/7] btrfs: Promote to unsigned long long before shifting
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]