Sorry Randy, I used my cellphone to send the previous mail, it is html. -----Original Message----- From: Randy Dunlap [mailto:rdunlap@xxxxxxxxxxxxx] Sent: Thursday, October 08, 2020 12:50 AM To: tianxianting (RD) <tian.xianting@xxxxxxx>; viro@xxxxxxxxxxxxxxxxxx Cc: linux-fsdevel@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx Subject: Re: [PATCH] fs: use correct parameter in notes of generic_file_llseek_size() On 10/7/20 8:20 AM, Tianxianting wrote: > hi, > > thanks Randy > > I checked the latest code, seems this patch not applied currently. Hi-- Please don't send html email. I'm pretty sure that the mailing list has dropped (discarded) your email because it was html. Probably only Al and I received your email. Al- Would you prefer that fs/ documentation patches go to someone else for merging? maybe Andrew? Thanks. PS: I can't tell if I am writing an html email or not... :( > ________________________________ > 发件人: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > 发送时间: Friday, September 11, 2020 10:57:24 AM > 收件人: tianxianting (RD); viro@xxxxxxxxxxxxxxxxxx > 抄送: linux-fsdevel@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > 主题: Re: [PATCH] fs: use correct parameter in notes of > generic_file_llseek_size() > > On 9/10/20 7:06 PM, Tianxianting wrote: >> Hi viro, >> Could I get your feedback? >> This patch fixed the build warning, I think it can be applied, thanks >> :) >> >> -----Original Message----- >> From: tianxianting (RD) >> Sent: Saturday, September 05, 2020 3:15 PM >> To: viro@xxxxxxxxxxxxxxxxxx >> Cc: linux-fsdevel@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; >> tianxianting (RD) <tian.xianting@xxxxxxx> >> Subject: [PATCH] fs: use correct parameter in notes of >> generic_file_llseek_size() >> >> Fix warning when compiling with W=1: >> fs/read_write.c:88: warning: Function parameter or member 'maxsize' not described in 'generic_file_llseek_size' >> fs/read_write.c:88: warning: Excess function parameter 'size' description in 'generic_file_llseek_size' >> >> Signed-off-by: Xianting Tian <tian.xianting@xxxxxxx> > > Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > Thanks. > >> --- >> fs/read_write.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/read_write.c b/fs/read_write.c index >> 5db58b8c7..058563ee2 100644 >> --- a/fs/read_write.c >> +++ b/fs/read_write.c >> @@ -71,7 +71,7 @@ EXPORT_SYMBOL(vfs_setpos); >> * @file: file structure to seek on >> * @offset: file offset to seek to >> * @whence: type of seek >> - * @size: max size of this file in file system >> + * @maxsize: max size of this file in file system >> * @eof: offset used for SEEK_END position >> * >> * This is a variant of generic_file_llseek that allows passing in a >> custom >> > > > -- > ~Randy > -- ~Randy
