On Sat, Sep 26, 2020 at 11:20:50AM +0200, Christoph Hellwig wrote: > This allows keeping the LOOKUP_ROOT case for vfs_path_lookup entirely > out of the normal fast path. ... saving you all of a if (unlikely(root)) {....} on it. Not worth it, and > + struct nameidata nd; > + > + return filename_lookup(AT_FDCWD, getname_kernel(name), flags, path, > + &nd); is something I would rather avoid on the general principles - better have set_nameidata()/restore_nameidata() done always to a local variable. Makes for somewhat easier analysis. IOW, NAK