On Wed, Sep 16, 2020 at 6:18 PM Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > But if this is non-truncate setattr then server will not kill suid/sgid. > So continue to send ATTR_MODE to kill suid/sgid for non-truncate setattr, > even if ->handle_killpriv_v2 is enabled. Sending ATTR_MODE doesn't make sense, since that is racy. The refresh-recalculate makes the race window narrower, but it doesn't eliminate it. I think I suggested sending write synchronously if suid/sgid/caps are set. Do you see a problem with this? Does this affect anything other than cached writes? Thanks, Miklos
