On Mon, Sep 21, 2020 at 04:34:27PM +0200, Christoph Hellwig wrote: > Explicitly check for the magic value insted of implicitly relying on > its numeric representation. Also drop the rather pointless unlikely > annotation. See above - I would rather have CHECK_IOVEC_ONLY gone. The reason for doing these access_ok() in the same loop is fairly weak, especially since you are checking type on each iteration. Might as well do that in a separate loop afterwards.