On Thu, Sep 17, 2020 at 11:11:15PM +0100, Matthew Wilcox wrote: > On Thu, Sep 17, 2020 at 03:05:00PM -0700, Darrick J. Wong wrote: > > > -static loff_t > > > -iomap_zero_range_actor(struct inode *inode, loff_t pos, loff_t count, > > > - void *data, struct iomap *iomap, struct iomap *srcmap) > > > +static loff_t iomap_zero_range_actor(struct inode *inode, loff_t pos, > > > + loff_t length, void *data, struct iomap *iomap, > > > > Any reason not to change @length and the return value to s64? > > Because it's an actor, passed to iomap_apply, so its types have to match. > I can change that, but it'll be a separate patch series. Ah, right. I seemingly forgot that. :( Carry on. Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --D
