On Thu, Sep 17, 2020 at 01:12:12PM -0400, Jeff King wrote: > On Thu, Sep 17, 2020 at 08:37:19AM -0700, Junio C Hamano wrote: > > Am I reading the above correctly? > > That's my understanding. It gets trickier with refs (which I think we > also ought to consider fsyncing), as we may create arbitrarily deep > hierarchies (so we'd have to keep track of which parts got created, or > just conservatively fsync up the whole hierarchy). Yeah, it definitely gets trickier, but hopefully not by much. I appreciate Christoph's explanation, and certainly buy into it. I can't think of any reason why we wouldn't want to apply the same reasoning to storing refs, too. It shouldn't be a hold-up for this series, though. > It gets a lot easier if we move to reftables that have a more > predictable file/disk structure. In the sense that we don't have to worry about arbitrary-depth loose references, yes, but I think we'll still have to deal with both cases. > -Peff Thanks, Taylor
