On Tue, Sep 08, 2020 at 06:32:51PM -0700, Darrick J. Wong wrote:
> +static inline void copy_to_xfs_dqblk_ts(const struct fs_disk_quota *d,
> + __s32 *timer_lo, __s8 *timer_hi, s64 timer)
> +{
> + *timer_lo = timer;
> + if (d->d_fieldmask & FS_DQ_BIGTIME)
> + *timer_hi = timer >> 32;
> + else
> + *timer_hi = 0;
> +}
I'm still confused by this. What breaks if you just do:
*timer_lo = timer;
*timer_hi = timer >> 32;
> memset(dst, 0, sizeof(*dst));
> + if (want_bigtime(src->d_ino_timer) || want_bigtime(src->d_spc_timer) ||
> + want_bigtime(src->d_rt_spc_timer))
> + dst->d_fieldmask |= FS_DQ_BIGTIME;
You still need this (I guess? In case somebody's written to the
d_padding2 field?)
