On Tue, Sep 08, 2020 at 01:47:06PM +0530, Pradeep P V K wrote: > Changes since V3: > - Fix smatch warnings. > > Changes since V2: > - Moved the spin lock from fuse_copy_pages() to fuse_ref_page(). > > Changes since V1: > - Modified the logic as per kernel v5.9-rc1. > - Added Reported by tag. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Umm, the way this is written, it looks like Dan reported the original bug rather than a bug in v3. The usual way is to credit Dan in the 'Changes since' rather than putting in a 'Reported-by'. > static int fuse_ref_page(struct fuse_copy_state *cs, struct page *page, > - unsigned offset, unsigned count) > + unsigned offset, unsigned count, struct fuse_conn *fc) I'm no expert on fuse, but it looks to me like you should put a pointer to the fuse_conn in struct fuse_copy_state rather than passing it down through all these callers.
