On 9/7/20 2:15 PM, Matthew Wilcox wrote: > On Mon, Aug 31, 2020 at 12:08:10PM -0600, Jens Axboe wrote: >> We have a set of flags that are shared between the two and inherired >> in kiocb_set_rw_flags(), but we check and set these individually. >> Reorder the IOCB flags so that the bottom part of the space is synced >> with the RWF flag space, and then we can do them all in one mask and >> set operation. >> >> The only exception is RWF_SYNC, which needs to mark IOCB_SYNC and >> IOCB_DSYNC. Do that one separately. >> >> This shaves 15 bytes of text from kiocb_set_rw_flags() for me. >> >> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx> > > Suggested-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> Added -- Jens Axboe