Re: [PATCH v3] fs: Remove duplicated flag O_NDELAY occurring twice in VALID_OPEN_FLAGS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 06, 2020 at 10:39:49PM +0000, Krzysztof Wilczyński wrote:
> The O_NDELAY flag occurs twice in the VALID_OPEN_FLAGS definition, this
> change removes the duplicate.  There is no change to the functionality.
> 
> Note, that the flags O_NONBLOCK and O_NDELAY are not duplicates, as
> values of these flags are platform dependent, and on platforms like
> Sparc O_NONBLOCK and O_NDELAY are not the same.
> 
> This has been done that way to maintain the ABI compatibility with
> Solaris since the Sparc port was first introduced.
> 
> This change resolves the following Coccinelle warning:
> 
>   include/linux/fcntl.h:11:13-21: duplicated argument to & or |
> 
> Signed-off-by: Krzysztof Wilczyński <kw@xxxxxxxxx>

Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux