On Tue, Sep 1, 2020 at 4:26 PM Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > > Hi Miklos, > > I am testing fuse dax branch now. To begin with here are couple of > simple fixes to make sure I/O is going through dax path. > > Either you can roll these fixes into existing patches or apply on > top. > > I ran blogbench workload and some fio mmap jobs and these seem to be > running fine after these fixes. Thanks for testing and fixing. Pushed a rerolled series to #for-next. Would be good if you cour retest. There's one checkpatch warning I'm unsure about: | WARNING: Using vsprintf specifier '%px' potentially exposes the kernel memory layout, if you don't really need the address please consider using '%p'. | #173: FILE: fs/fuse/virtio_fs.c:812: | + dev_dbg(&vdev->dev, "%s: window kaddr 0x%px phys_addr 0x%llx len 0x%llx\n", | + __func__, fs->window_kaddr, cache_reg.addr, cache_reg.len); | | total: 0 errors, 1 warnings, 175 lines checked | | NOTE: For some of the reported defects, checkpatch may be able to | mechanically convert to the typical style using --fix or --fix-inplace. | | patches/virtio_fs-dax-set-up-virtio_fs-dax_device.patch has style problems, please review. Do you think that the kernel address in the debug output is necessary? Thanks, Miklos
