On Thu, Aug 13, 2020 at 05:04:11PM -0400, Josef Bacik wrote: > + len = scnprintf(buffer, *lenp, "0x%04x\n", *(unsigned int *) table->data); This adds a really hard to read overlong long line. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>