From: Leon Romanovsky <leonro@xxxxxxxxxx> The simple_dname() is declared in internal header file but the declaration is missing in d_path.c. The compilation with W=1 generates the following GCC warning. fs/d_path.c:311:7: warning: no previous prototype for 'simple_dname' [-Wmissing-prototypes] 311 | char *simple_dname(struct dentry *dentry, char *buffer, int buflen) | ^~~~~~~~~~~~ Fixes: 7e5f7bb08b8c ("unexport simple_dname()") Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx> --- Changelog: v1: Dropped "extern" removal chunk v0: https://lore.kernel.org/lkml/20200819083259.919838-1-leon@xxxxxxxxxx/ --- fs/d_path.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/d_path.c b/fs/d_path.c index 0f1fc1743302..4b89448cc78e 100644 --- a/fs/d_path.c +++ b/fs/d_path.c @@ -8,6 +8,8 @@ #include <linux/prefetch.h> #include "mount.h" +#include "internal.h" + static int prepend(char **buffer, int *buflen, const char *str, int namelen) { *buflen -= namelen; -- 2.26.2