From: Leon Romanovsky <leonro@xxxxxxxxxx> The simple_dname() is declared in internal header file as extern and this generates the following GCC warning. fs/d_path.c:311:7: warning: no previous prototype for 'simple_dname' [-Wmissing-prototypes] 311 | char *simple_dname(struct dentry *dentry, char *buffer, int buflen) | ^~~~~~~~~~~~ Instead of that extern, reuse the fact that internal.h file is internal to fs/* and declare simple_dname() like any other function. Fixes: 7e5f7bb08b8c ("unexport simple_dname()") Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx> --- fs/d_path.c | 2 ++ fs/internal.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/d_path.c b/fs/d_path.c index 0f1fc1743302..4b89448cc78e 100644 --- a/fs/d_path.c +++ b/fs/d_path.c @@ -8,6 +8,8 @@ #include <linux/prefetch.h> #include "mount.h" +#include "internal.h" + static int prepend(char **buffer, int *buflen, const char *str, int namelen) { *buflen -= namelen; diff --git a/fs/internal.h b/fs/internal.h index 10517ece4516..2def264272f4 100644 --- a/fs/internal.h +++ b/fs/internal.h @@ -164,7 +164,7 @@ extern int d_set_mounted(struct dentry *dentry); extern long prune_dcache_sb(struct super_block *sb, struct shrink_control *sc); extern struct dentry *d_alloc_cursor(struct dentry *); extern struct dentry * d_alloc_pseudo(struct super_block *, const struct qstr *); -extern char *simple_dname(struct dentry *, char *, int); +char *simple_dname(struct dentry *d, char *buf, int len); extern void dput_to_list(struct dentry *, struct list_head *); extern void shrink_dentry_list(struct list_head *); -- 2.26.2