This helper uses kvmalloc, not vmalloc, so rename it to kvmemdup_user to make it clear we're using kvmalloc() and will need to use kvfree(). Signed-off-by: Josef Bacik <josef@xxxxxxxxxxxxxx> --- arch/x86/kvm/cpuid.c | 6 +++--- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 2 +- drivers/tty/vt/consolemap.c | 2 +- include/linux/string.h | 2 +- mm/util.c | 6 +++--- sound/core/control.c | 4 ++-- virt/kvm/kvm_main.c | 4 ++-- 7 files changed, 13 insertions(+), 13 deletions(-) diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index 3fd6eec202d7..22834ea499ee 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -200,9 +200,9 @@ int kvm_vcpu_ioctl_set_cpuid(struct kvm_vcpu *vcpu, if (cpuid->nent > KVM_MAX_CPUID_ENTRIES) goto out; if (cpuid->nent) { - cpuid_entries = vmemdup_user(entries, - array_size(sizeof(struct kvm_cpuid_entry), - cpuid->nent)); + cpuid_entries = kvmemdup_user(entries, + array_size(sizeof(struct kvm_cpuid_entry), + cpuid->nent)); if (IS_ERR(cpuid_entries)) { r = PTR_ERR(cpuid_entries); goto out; diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c index 7a2430e34e00..c2f973aa3680 100644 --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c @@ -147,7 +147,7 @@ static int virtio_gpu_execbuffer_ioctl(struct drm_device *dev, void *data, bo_handles = NULL; } - buf = vmemdup_user(u64_to_user_ptr(exbuf->command), exbuf->size); + buf = kvmemdup_user(u64_to_user_ptr(exbuf->command), exbuf->size); if (IS_ERR(buf)) { ret = PTR_ERR(buf); goto out_unused_fd; diff --git a/drivers/tty/vt/consolemap.c b/drivers/tty/vt/consolemap.c index 5947b54d92be..2cffa8b3c74b 100644 --- a/drivers/tty/vt/consolemap.c +++ b/drivers/tty/vt/consolemap.c @@ -542,7 +542,7 @@ int con_set_unimap(struct vc_data *vc, ushort ct, struct unipair __user *list) if (!ct) return 0; - unilist = vmemdup_user(list, array_size(sizeof(struct unipair), ct)); + unilist = kvmemdup_user(list, array_size(sizeof(struct unipair), ct)); if (IS_ERR(unilist)) return PTR_ERR(unilist); diff --git a/include/linux/string.h b/include/linux/string.h index 21bb6d3d88c4..a6f7218124a0 100644 --- a/include/linux/string.h +++ b/include/linux/string.h @@ -11,7 +11,7 @@ extern char *strndup_user(const char __user *, long); extern void *memdup_user(const void __user *, size_t); -extern void *vmemdup_user(const void __user *, size_t); +extern void *kvmemdup_user(const void __user *, size_t); extern void *kvmemdup_user_nul(const void __user *, size_t); extern void *memdup_user_nul(const void __user *, size_t); diff --git a/mm/util.c b/mm/util.c index cf454d57d3e2..f434634b6ba3 100644 --- a/mm/util.c +++ b/mm/util.c @@ -183,7 +183,7 @@ void *memdup_user(const void __user *src, size_t len) EXPORT_SYMBOL(memdup_user); /** - * vmemdup_user - duplicate memory region from user space + * kvmemdup_user - duplicate memory region from user space * * @src: source address in user space * @len: number of bytes to copy @@ -191,7 +191,7 @@ EXPORT_SYMBOL(memdup_user); * Return: an ERR_PTR() on failure. Result may be not * physically contiguous. Use kvfree() to free. */ -void *vmemdup_user(const void __user *src, size_t len) +void *kvmemdup_user(const void __user *src, size_t len) { void *p; @@ -206,7 +206,7 @@ void *vmemdup_user(const void __user *src, size_t len) return p; } -EXPORT_SYMBOL(vmemdup_user); +EXPORT_SYMBOL(kvmemdup_user); /** * kvmemdup_user_nul - duplicate memory region from user space and NUL-terminate diff --git a/sound/core/control.c b/sound/core/control.c index aa0c0cf182af..b712f4d261de 100644 --- a/sound/core/control.c +++ b/sound/core/control.c @@ -1297,7 +1297,7 @@ static int replace_user_tlv(struct snd_kcontrol *kctl, unsigned int __user *buf, if (size > 1024 * 128) /* sane value */ return -EINVAL; - container = vmemdup_user(buf, size); + container = kvmemdup_user(buf, size); if (IS_ERR(container)) return PTR_ERR(container); @@ -1365,7 +1365,7 @@ static int snd_ctl_elem_init_enum_names(struct user_element *ue) if (ue->info.value.enumerated.names_length > 64 * 1024) return -EINVAL; - names = vmemdup_user((const void __user *)user_ptrval, + names = kvmemdup_user((const void __user *)user_ptrval, ue->info.value.enumerated.names_length); if (IS_ERR(names)) return PTR_ERR(names); diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 737666db02de..1111780ccefd 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -3814,8 +3814,8 @@ static long kvm_vm_ioctl(struct file *filp, goto out; if (routing.nr) { urouting = argp; - entries = vmemdup_user(urouting->entries, - array_size(sizeof(*entries), + entries = kvmemdup_user(urouting->entries, + array_size(sizeof(*entries), routing.nr)); if (IS_ERR(entries)) { r = PTR_ERR(entries); -- 2.24.1